Omgdontdie

As a human or dwarf? I really want to believe Ironfoe is still competitive, esp with buffs. Other race, not so much. Also concerning Ironfoe, shouldnt the formula be as simple as (WhiteMHConnects+YellowConnects)*0.05*(BaseDamage+NetAP/14*BaseSpeed)*WhiteHitMod*2 if we assume a 5% proc rate (although testing is making me lean more towards 6%)? This doesn't bring into account the rage gained from procs, but I think its safe to assume you will never be rage starved at this gear level. Another thing, in your full buffs dagger setup spreadsheet, I don't see DM buffs or R.O.I.Ds being included. For alliance, weapon stones also become relevant. If you tweak this a little bit, and your race is human/dwarf I think you might see Ironfoe+Anubisath Warhammer skyrocket again.

Warrior abilities Sunder Armor, Bloodthirst, Execute, and Shield Slam are not triggering main hand procs. While initially I thought this may be working as intended, after reviewing some old clips and former blizzard patch notes, this is clearly not the case. This also has major implications when it comes to the undertuned state of Thunderfury. Currently, there are complaints that the proc rate of Thunderfury is undertuned, however, looking at the sql files, the proc rate of Thunderfury seems more than reasonable. The problem is not that Thunderfury or other chance-on-hit weapons are undertuned... it is that half of protection warrior abilities are bugged. Tests were done with a sample size of at least 100, both with Ironfoe with crusader and a 2.8 speed green with fiery. The results match my understanding of the source code and the sample size is large enough to eliminate RNG. Tests were done while hit capped and without Hand of Justice. You can find my original thread "Ironfoe Testing" in the warrior class forum, and below are my github bugtracker posts with evidence and proposed solutions. https://github.com/elysium-project/server/issues/1011 https://github.com/elysium-project/server/issues/1012 https://github.com/elysium-project/server/issues/1021 https://github.com/elysium-project/server/issues/1023 Best, Omgdontdie

All four bug tracker posts now supply indisputable evidence that their respective spells (Sunder Armor, Bloodthirst, Execute, Shield Slam) trigger main hand procs. Simple code solutions which are extremely easy to implement have been proposed. Rest is up to the devs. Omg out.

Wow... AQ team denied the change... No wonder it isnt working even though the patch notes said Shield Slam should be working correctly.

Side note... Shield Bash fix and Shield Slam + Execute fix were two separate fixes. Is it possible that the second one never got pushed out to live?

Bought a 2.8 speed 1h and got fiery to make sure my sample size will never be too small. Currently Bloodthirst, Shield Slam, and Execute are confirmed bugs (evidence found) and Sunder Armor clearly doesnt proc but I havent found proof yet. https://github.com/elysium-project/server/issues/1011 https://github.com/elysium-project/server/issues/1012 https://github.com/elysium-project/server/issues/1021 https://github.com/elysium-project/server/issues/1023

Shield Bash is proccing main hand. Shield Slam is not.

Did some testing with Execute, and even though the code says it is fixed it still isnt proccing. They might have the wrong spell ID. Tested shield bash and it procs main hand weapon, so the fix should work as long as the spell ID is correct. The same fix should work for BT and SA, ill look into it.

I've tested with pummel enough times to feel confident that it does not proc Ironfoe - nothing unexpected.

Did some digging, and found evidence that supports Bloodthirst generating procs. If you look closely at approx 1:42, you see two windfury procs occurring back to back - too close together for it to be from a single main hand swing. The only reasonable conclusion is that Bloodthirst (which was cast the exact moment the windfury procced) generated the proc. I don't play horde, but if I recall correctly, windfury is essentially the same as a main hand chance-on-hit enchant. Note that because this is in Naxx, and by this point extra attack chain procs were fixed, this is also not possible.

When you say is this how the spells behave in the code? Or how they are supposed to work? I get a strong intuitive feeling that SA and BT should generate procs, but I haven't found definitive evidence on this. If abilities like shield bash/shield slam are supposed to generate procs, it feels wrong to not have SA and BT generate procs. About shield slam, a past patch note says it should proc main hand weapon attacks, but I haven't tested this nor have I looked at the code https://elysium-project.org/updates/2016-12-15 I also think I have seen Ironfoe proc off pummel, but my memory may be deceiving me. I will test this now.

Thanks to a guildie who helped me with some of the digging, we think the requirements for Ironfoe proccing off spells are the following: -The attack has to be in the physical spell school -The damagetype must be melee -The attack must be a hit or crit -Damage must be greater than zero Sunder doesn't fit the last category. Bloodthrist could have just been a small sample size (or damagetype could be different, havent looked). The problem is that I have no proof on whether or not Sunder Armor is supposed to be proccing chance on hit anyway. I just thought it was odd. If anyone has posts from 2007 or screenshots of SA proccing chance on hit, id love to make a bug report.

Even with the nerfed proc rate, I would guess Ironfoe+Anubisath could outperform daggers with world buffs just because it scales so well.

I wouldn't mind gear upgrades for Darrowshire. Ranking there is hell considering the low pop and free-for-all system since there isn't a real premade on ally side. Even having a few more casuals farming for r9 shoulders would help increase the pool for those at the top. Its only a matter of time before BR1 disappears on non-AV weeks.

Ironfoe feels like it was stealth nerfed again. Logged on and noticed low proc rates and decided to run procwatch on it. What was near 5% now seems to be in the 2%-3% range now. Edit: After expanding my sample size, I think I was able to get it closer to 5%. Seriously long bad luck streaks do happen it seems.