Warrior Abilities Don't Trigger Procs (Evidence and Possible Solutions Provided)

Omgdontdie · June 8, 2017

Warrior abilities Sunder Armor, Bloodthirst, Execute, and Shield Slam are not triggering main hand procs. While initially I thought this may be working as intended, after reviewing some old clips and former blizzard patch notes, this is clearly not the case. This also has major implications when it comes to the undertuned state of Thunderfury. Currently, there are complaints that the proc rate of Thunderfury is undertuned, however, looking at the sql files, the proc rate of Thunderfury seems more than reasonable. The problem is not that Thunderfury or other chance-on-hit weapons are undertuned... it is that half of protection warrior abilities are bugged.

Tests were done with a sample size of at least 100, both with Ironfoe with crusader and a 2.8 speed green with fiery. The results match my understanding of the source code and the sample size is large enough to eliminate RNG. Tests were done while hit capped and without Hand of Justice.

You can find my original thread "Ironfoe Testing" in the warrior class forum, and below are my github bugtracker posts with evidence and proposed solutions.

https://github.com/elysium-project/server/issues/1011

https://github.com/elysium-project/server/issues/1012

https://github.com/elysium-project/server/issues/1021

https://github.com/elysium-project/server/issues/1023

Best,

Omgdontdie